EDG-217 Houston: Add BulkTagBrowser SDK interface#56
Closed
EDG-217 Houston: Add BulkTagBrowser SDK interface#56
Conversation
4 tasks
codepitbull
reviewed
Mar 18, 2026
src/main/java/com/hivemq/adapter/sdk/api/discovery/BulkTagBrowser.java
Outdated
Show resolved
Hide resolved
codepitbull
force-pushed
the
feature/EDG-217-houston-implementation
branch
from
aa1e713 to
1d6c76c
Compare
marregui
force-pushed
the
feature/EDG-217-houston-implementation
branch
2 times, most recently
from
0aac7cc to
f4c798f
Compare
mschoenert-hivemq
changed the title
The licenseMain task requires Copyright 2023-present per the repo's HEADER file. The Houston discovery files had 2019-present.
marregui
force-pushed
the
feature/EDG-217-houston-implementation
branch
from
f4c798f to
0f7c60b
Compare
Rename the browse parameter from rootNodeId to rootId to be protocol-agnostic. Document namespaceUri and namespaceIndex as protocol-specific context fields, not strictly OPC UA namespaces.
Move BulkTagBrowser, BrowsedNode, and BrowseException out of the adapter SDK per Martin's directive — the SDK is public and committing to OPC-UA-shaped abstractions before implementing adapter #2 is premature. The types now live in hivemq-edge (OPC UA module) under a neutral package (com.hivemq.edge.adapters.browse).
Contributor
Author
|
Closing — per Martin's review feedback, Houston ships without SDK changes. The browse types (BulkTagBrowser, BrowsedNode, BrowseException) now live inside the OPC UA module under a neutral package ( See the updated hivemq-edge PR (#1444) for the new approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Adapter SDK extension for the Houston feature (EDG-217) — bulk device tag browsing and import for OPC UA adapters.
Three new types in
com.hivemq.adapter.sdk.api.discovery:BulkTagBrowser— mixin interface that adapters implement alongsideProtocolAdapterto support bulk address-space browsing. Single method:List<BrowsedNode> browse(rootNodeId, maxDepth). Returns a pre-sorted list of discovered variable nodes.BrowsedNode— Java record (11 fields) representing a discovered device variable node: 7 device-sourced fields (nodePath, namespaceUri, namespaceIndex, nodeId, dataType, accessLevel, nodeDescription) and 4 generated defaults (tagNameDefault, tagDescription, northboundTopicDefault, southboundTopicDefault).BrowseException— checked exception for browse failures.This is purely additive — no existing interfaces or classes are modified. Runtime detection is via
adapter instanceof BulkTagBrowser. Future protocol adapters (Modbus device profiles, EtherNet/IP, etc.) can opt in by implementing the same interface.Related PRs
Linear ticket
EDG-217 — Houston Implementation
Test plan
./gradlew :hivemq-edge-adapter-sdk:compileJavapassesBulkTagBrowserand passes 48 integration tests